Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qgis: 3.38.2 -> 3.38.3 #342248

Merged
merged 2 commits into from
Sep 16, 2024
Merged

qgis: 3.38.2 -> 3.38.3 #342248

merged 2 commits into from
Sep 16, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Sep 16, 2024

Description of changes

Update QGIS to the lastest patch release:

List of changes:
qgis/QGIS@final-3_38_2^...final-3_38_3

Also, drop redundant CMAKE_BUILD_TYPE setting.

CMAKE_BUILD_TYPE=Release is set by default in

nixpkgs/pkgs/by-name/cm/cmake/setup-hook.sh

Line 113 in 040bd3d

prependToVar cmakeFlags "-DCMAKE_BUILD_TYPE=${cmakeBuildType:-Release}"

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

l0b0
l0b0 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM; untested. Thanks!

@sikmir sikmir merged commit 0299c3b into NixOS:master Sep 16, 2024
28 of 30 checks passed
imincik added a commit to imincik/geospatial-nix that referenced this pull request Sep 19, 2024
@imincik
qgis: 3.38.2 -> 3.38.3
11265a8 
Nixpkgs PR:
NixOS/nixpkgs#342248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0b0 l0b0 l0b0 approved these changes

@autra autra Awaiting requested review from autra

@nialov nialov Awaiting requested review from nialov

@lsix lsix Awaiting requested review from lsix

@sikmir sikmir Awaiting requested review from sikmir

@nh2 nh2 Awaiting requested review from nh2

@willcohen willcohen Awaiting requested review from willcohen

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imincik @l0b0 @sikmir